Added add_periodic_callback coroutine typing #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `add_periodic_callback` method only had the `Callable` type hint while it also supports asyncio functions. This adds that type hint so `pyright` won't complain anymore :)
philippjfr
reviewed
Jul 25, 2022
philippjfr
reviewed
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #3714 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 207 207
Lines 29654 29678 +24
=======================================
+ Hits 24779 24801 +22
- Misses 4875 4877 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Test failures are unrelated, merging. |
|
Thanks @wolph! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add_periodic_callbackmethod only had theCallabletype hint while it also supports asyncio functions. This adds that type hint sopyrightwon't complain anymore :)