Use non-default Parameterized name as Select label #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3755 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 213 213
Lines 30958 30971 +13
=======================================
+ Hits 26067 26080 +13
Misses 4891 4891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jbednar
reviewed
Aug 15, 2022
| @@ -37,6 +37,9 @@ | |||
| bokeh_version = Version(bokeh.__version__) | |||
|
|
|||
|
|
|||
| PARAM_NAME_PATTERN = re.compile('^.*\d{5}$') | |||
There was a problem hiding this comment.
This seems like something that should be internal to Param (a method or function to determine if a name is non-default), not hardcoded into Panel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3688