Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not calculate embed state for disabled widgets #3757

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

philippjfr
Copy link
Member

Fixes #1295

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #3757 (babc310) into master (4a9b4d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3757      +/-   ##
==========================================
+ Coverage   84.21%   84.23%   +0.01%     
==========================================
  Files         213      213              
  Lines       30993    31002       +9     
==========================================
+ Hits        26102    26113      +11     
+ Misses       4891     4889       -2     
Flag Coverage Δ
ui-tests 33.99% <10.00%> (-0.01%) ⬇️
unitexamples-tests 77.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/embed.py 86.87% <100.00%> (ø)
panel/tests/io/test_embed.py 99.42% <100.00%> (+0.01%) ⬆️
panel/io/document.py 66.97% <0.00%> (+1.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit ee73911 into master Aug 14, 2022
@philippjfr philippjfr deleted the embed_disabled branch August 14, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate parameter 'disabled' to function 'embed'
1 participant