Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting number rather than string in tabulators #3999

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Sorting number rather than string in tabulators #3999

merged 2 commits into from
Oct 14, 2022

Conversation

liu-kan
Copy link
Contributor

@liu-kan liu-kan commented Oct 14, 2022

Tabulator JS has its Built In Sorters for data other than string.
Default behaviours for sorting data, include numbers, in panel tabulator, is treating them as string.
This PR fix this issue.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3999 (9dfd0c3) into master (a7f880f) will decrease coverage by 8.96%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##           master    #3999      +/-   ##
==========================================
- Coverage   83.67%   74.71%   -8.97%     
==========================================
  Files         223      223              
  Lines       33048    33104      +56     
==========================================
- Hits        27654    24734    -2920     
- Misses       5394     8370    +2976     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 74.71% <63.33%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 9.50% <8.33%> (-89.46%) ⬇️
panel/tests/widgets/test_tables.py 99.66% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 87.36% <100.00%> (-1.05%) ⬇️
panel/tests/ui/widgets/test_input.py 11.34% <0.00%> (-88.08%) ⬇️
panel/tests/ui/layout/test_accordion.py 14.72% <0.00%> (-85.28%) ⬇️
panel/tests/ui/widgets/test_sliders.py 15.42% <0.00%> (-84.58%) ⬇️
panel/tests/ui/layout/test_card.py 18.01% <0.00%> (-81.99%) ⬇️
panel/tests/ui/io/test_convert.py 16.66% <0.00%> (-78.71%) ⬇️
panel/tests/ui/test_reactive.py 26.53% <0.00%> (-73.47%) ⬇️
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr requested a review from maximlt October 14, 2022 10:25
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change I also found that was required to fix #3976, thanks a lot @liu-kan !!!

@philippjfr philippjfr merged commit 9a5d7e2 into holoviz:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants