Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deployment to Hugging Face Spaces #4143

Merged
merged 7 commits into from
Dec 10, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 22, 2022

@philippjfr
Copy link
Member

Happy to merge this in the current form. However once we get started on the how-to section we should split this out into separate "How to deploy to " guides.

@philippjfr
Copy link
Member

Would suggest you set up pre-commit btw, see here.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Nov 22, 2022

Thanks. Would love to have it working. But I've given up on installing panel and HoloViz for development. I've waisted too much time trying.

Give me something that can install in max 5 minutes without issues and I will do it. It is normally closer to 1 hour than 5 minutes.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Nov 23, 2022

I will clean up any issues in the automated checks run here, but don't expect to do more now.

Please share on social https://www.linkedin.com/posts/marcskovmadsen_machinelearning-deeplearning-python-activity-7001076465718980609-W30M?utm_source=share&utm_medium=member_desktop

When you merge @philippjfr please don't delete the branch because I've shared links to the preliminary docs. Instead let me know and I will update the links.

When that is done we can delete the branch. Thanks.

@philippjfr
Copy link
Member

Thanks @MarcSkovMadsen!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #4143 (ad6460e) into master (cd15358) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4143   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         224      224           
  Lines       33394    33394           
=======================================
+ Hits        27911    27912    +1     
+ Misses       5483     5482    -1     
Flag Coverage Δ
ui-tests 37.64% <ø> (+<0.01%) ⬆️
unitexamples-tests 74.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/util.py 89.32% <0.00%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maximlt
Copy link
Member

maximlt commented Nov 24, 2022

@MarcSkovMadsen unlike pyctdev, pre-commit is easy to install and run (well you don't even run it, it runs automatically on commits). It's becoming a standard and I'd say is part of the modern developer stack you're often calling for ;)

@MarcSkovMadsen
Copy link
Collaborator Author

I can see the tests fail. But I don't see it as related to my PR.

image

@MarcSkovMadsen
Copy link
Collaborator Author

@MarcSkovMadsen unlike pyctdev, pre-commit is easy to install and run (well you don't even run it, it runs automatically on commits). It's becoming a standard and I'd say is part of the modern developer stack you're often calling for ;)

So it does not require me to first get the developer environment up and running? How can it run without those things installed?

@hoxbro
Copy link
Member

hoxbro commented Nov 24, 2022

I can see the tests fail. But I don't see it as related to my PR.

They aren't. I will merge master into this PR.

@maximlt
Copy link
Member

maximlt commented Nov 29, 2022

So it does not require me to first get the developer environment up and running? How can it run without those things installed?

As far as I understand pre-commit doesn't install the tools that it runs (e.g. flake8) in your dev environment, it acts as a another "package manager". So I think all you need is to install it (maybe globally with pipx, I haven't tried that though) and then run pre-commit install.

@philippjfr
Copy link
Member

Merging this. I have set up a HoloViz org on huggingface but your example is nice and I want to get a release out.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in the near future I think we should split the deployment guide into individual how-to guides.

@philippjfr philippjfr merged commit 90a8503 into master Dec 10, 2022
@philippjfr philippjfr deleted the feature/hugging-face-deployment branch December 10, 2022 16:16
@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Dec 10, 2022

Agree. But we should find a good way to contribute how tos. For me they are a bit like blog posts.

I've been thinking it would be powerful to release them continuously and use them for promotion: "did you know... here is how to.." I am also thinking, how could we get the community involved? Could the how tos bear the name of the author? And we would help promote the as they help the community?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use Panel on Hugging Face
4 participants