Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ace model to support Bokeh 3 #4449

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Update Ace model to support Bokeh 3 #4449

merged 2 commits into from
Feb 15, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 15, 2023

Update the Ace model to support Bokeh 3, but some sizing problems still exist. Though I think these problems are more general than related to the Ace model.

  1. stretch_both in a notebook (stretch_width works fine):
     Screenshot 2023-02-15 14 41 49
     Screenshot 2023-02-15 14 41 57
  2. Widget exceeds Tabs width
     Screenshot 2023-02-15 14 37 10
  3. Column does not respect the sizing_mode of Ace.
    import panel as pn
    
    pn.extension("ace")
    
    editor = pn.widgets.Ace(value="import sys", language="python", sizing_mode="stretch_width")
    pn.Row(editor).servable()  # Does not work
    pn.Row(editor, sizing_mode="stretch_width").servable()  # Does work
    editor.servable()  # Does work
    image

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #4449 (63a87db) into main (0cf1c5b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4449      +/-   ##
==========================================
- Coverage   81.80%   81.77%   -0.03%     
==========================================
  Files         238      238              
  Lines       34872    34872              
==========================================
- Hits        28528    28518      -10     
- Misses       6344     6354      +10     
Flag Coverage Δ
ui-tests 35.95% <0.00%> (-0.01%) ⬇️
unitexamples-tests 73.54% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/models/ace.py 91.66% <100.00%> (ø)
panel/io/reload.py 71.73% <0.00%> (-2.18%) ⬇️
panel/tests/util.py 90.09% <0.00%> (-1.81%) ⬇️
panel/io/callbacks.py 77.94% <0.00%> (-1.48%) ⬇️
panel/util/__init__.py 86.72% <0.00%> (-0.45%) ⬇️
panel/reactive.py 78.74% <0.00%> (-0.21%) ⬇️
panel/widgets/indicators.py 72.72% <0.00%> (-0.16%) ⬇️
panel/io/state.py 63.02% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

This is great, merging!

@philippjfr philippjfr merged commit aae2074 into main Feb 15, 2023
@philippjfr philippjfr deleted the update_ace branch February 15, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants