Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intro example #4652

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Improve intro example #4652

merged 1 commit into from
Apr 15, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #4651 and fixes some bugs.

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #4652 (8a57101) into main (e4bc8c2) will increase coverage by 9.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4652      +/-   ##
==========================================
+ Coverage   73.25%   83.17%   +9.91%     
==========================================
  Files         263      263              
  Lines       37228    37228              
==========================================
+ Hits        27270    30963    +3693     
+ Misses       9958     6265    -3693     
Flag Coverage Δ
ui-tests 39.65% <ø> (?)
unitexamples-tests 73.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense, thanks!

@philippjfr philippjfr merged commit 0df3be5 into main Apr 15, 2023
@philippjfr philippjfr deleted the feature/improve-ux-intro-example branch April 15, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help the user understand the code a bit more in the introduction/ reference example
2 participants