Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown rendering #4688

Merged
merged 14 commits into from
Apr 25, 2023
Merged

Improve markdown rendering #4688

merged 14 commits into from
Apr 25, 2023

Conversation

philippjfr
Copy link
Member

Improve Markdown renderering by using markdown-it-py as default.

Screen Shot 2023-04-25 at 11 04 41

Screen Shot 2023-04-25 at 11 05 07

  • Code sections

Screen Shot 2023-04-24 at 23 38 06

Screen Shot 2023-04-24 at 23 38 18

  • Tables

Screen Shot 2023-04-24 at 23 39 20

Screen Shot 2023-04-24 at 23 39 12

  • Code blocks

Screen Shot 2023-04-24 at 23 40 19

Screen Shot 2023-04-24 at 23 40 13

  • Add code copy button
  • Strikethrough

Screen Shot 2023-04-24 at 23 41 46

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #4688 (e6cc618) into main (bb9a7be) will decrease coverage by 0.03%.
The diff coverage is 79.36%.

@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
- Coverage   83.16%   83.13%   -0.03%     
==========================================
  Files         266      266              
  Lines       37453    37488      +35     
==========================================
+ Hits        31149    31167      +18     
- Misses       6304     6321      +17     
Flag Coverage Δ
ui-tests 39.62% <58.73%> (-0.03%) ⬇️
unitexamples-tests 73.24% <53.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/markup.py 89.77% <65.62%> (-4.04%) ⬇️
panel/tests/ui/io/test_server.py 73.52% <66.66%> (ø)
panel/tests/pane/test_markup.py 99.38% <100.00%> (+0.01%) ⬆️
panel/tests/test_interact.py 99.00% <100.00%> (ø)
panel/tests/ui/io/test_state.py 72.22% <100.00%> (ø)
panel/tests/ui/pane/test_markup.py 100.00% <100.00%> (ø)
panel/tests/ui/template/test_bootstraptemplate.py 100.00% <100.00%> (ø)
panel/tests/ui/template/test_fastgridtemplate.py 100.00% <100.00%> (ø)
panel/tests/ui/template/test_fastlisttemplate.py 100.00% <100.00%> (ø)
panel/tests/ui/template/test_materialtemplate.py 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit e400fad into main Apr 25, 2023
@philippjfr philippjfr deleted the markdown_renderer branch April 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant