Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to prepare for Param 2.0 #4757

Merged
merged 2 commits into from
May 2, 2023
Merged

Minor changes to prepare for Param 2.0 #4757

merged 2 commits into from
May 2, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 2, 2023

This PR fixes calls to Param's main warning, as in Param 2.0 the warning method is going to be removed from the Parameterized namespace and will only be available in the .param namespace.

This PR also removes an unused kwarg passed in a test to the HoloViews pane, spotted by Simon in holoviz/param#729.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #4757 (7dc9637) into main (5ec6ae6) will not change coverage.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##             main    #4757   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         268      268           
  Lines       37689    37689           
=======================================
  Hits        27595    27595           
  Misses      10094    10094           
Flag Coverage Δ
unitexamples-tests 73.21% <28.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/interact.py 74.30% <0.00%> (ø)
panel/io/embed.py 87.33% <0.00%> (ø)
panel/io/ipywidget.py 0.00% <0.00%> (ø)
panel/io/rest.py 31.63% <0.00%> (ø)
panel/param.py 86.61% <100.00%> (ø)
panel/tests/pane/test_holoviews.py 99.17% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@philippjfr philippjfr merged commit 02e215a into main May 2, 2023
@philippjfr philippjfr deleted the fix_param_warning branch May 2, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants