Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param 2: adapt one test to updated error message #5517

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Sep 16, 2023

Adapting one test to an improved error message changed in holoviz/param#824 that will be in Param 2.0.0a3 (not yet release)

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #5517 (5e10f50) into main (331abc5) will increase coverage by 11.15%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##             main    #5517       +/-   ##
===========================================
+ Coverage   72.47%   83.63%   +11.15%     
===========================================
  Files         276      276               
  Lines       40247    40249        +2     
===========================================
+ Hits        29168    33661     +4493     
+ Misses      11079     6588     -4491     
Flag Coverage Δ
ui-tests 41.47% <0.00%> (?)
unitexamples-tests 72.46% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/tests/test_param.py 99.36% <60.00%> (-0.08%) ⬇️

... and 71 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@philippjfr philippjfr merged commit a3746f3 into main Sep 18, 2023
@philippjfr philippjfr deleted the adapt_param2_error branch September 18, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants