Display value for player #6059
Closed
Display value for player #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6059 +/- ##
==========================================
+ Coverage 82.98% 83.91% +0.92%
==========================================
Files 295 300 +5
Lines 44038 44700 +662
==========================================
+ Hits 36543 37508 +965
+ Misses 7495 7192 -303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuang11
reviewed
Dec 18, 2023
ahuang11
reviewed
Dec 18, 2023
ahuang11
reviewed
Dec 18, 2023
ahuang11
reviewed
Dec 18, 2023
ahuang11
reviewed
Dec 18, 2023
ahuang11
reviewed
Dec 18, 2023
|
@philippjfr can you take a look at this? |
ahuang11
reviewed
Dec 19, 2023
ahuang11
reviewed
Dec 19, 2023
formatting changes Co-authored-by: Andrew <[email protected]>
|
This is looking great! In practice we mostly use |
…313/panel into display_value_for_player
philippjfr
reviewed
Jan 9, 2024
|
Superseded by #7060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player.demo.mp4
PR closes issue #229
Added display value for the Player widget
Added the param "value_location" to the Slider, which sets where the value is displayed
Planning on adding support for the Name param as well