Tabulator: Fix editing a table that contains a timezone-aware datetime column #6879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6879 +/- ##
==========================================
- Coverage 81.52% 81.06% -0.47%
==========================================
Files 319 319
Lines 46895 46915 +20
==========================================
- Hits 38233 38030 -203
- Misses 8662 8885 +223 ☔ View full report in Codecov by Sentry. |
hoxbro
reviewed
May 30, 2024
philippjfr
reviewed
May 30, 2024
philippjfr
approved these changes
May 31, 2024
philippjfr
reviewed
Jun 27, 2024
Comment on lines
+1238
to
+1239
| .dt.tz_convert('utc') | ||
| .dt.tz_localize(None) |
There was a problem hiding this comment.
What is the intention behind these last two lines? This will soon cause pandas to error and also I'm quite confused. This localizes in the original provided timezone, then shifts it to UTC, which seems wrong.
There was a problem hiding this comment.
I've made a change here 8d1e9f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6673