Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out empty plotly_selected events #7312

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

alexcjohnson
Copy link
Contributor

plotly.js emits plotly_selected events with empty data on single click - odd behavior but it has been kept for backward compatibility. In Dash these are filtered out (that's the if (!isNil(selected)). I'm just replicating that behavior here, so that an empty selected_data param truly means there's no selection.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (32b147d) to head (8d08ac5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7312   +/-   ##
=======================================
  Coverage   82.19%   82.20%           
=======================================
  Files         337      337           
  Lines       50394    50394           
=======================================
+ Hits        41422    41424    +2     
+ Misses       8972     8970    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Good catch, thank you!

@philippjfr philippjfr merged commit f426769 into holoviz:main Sep 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants