-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatetimeSlider widget #7374
Conversation
I’m think about the unit for |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7374 +/- ##
==========================================
+ Coverage 81.42% 82.23% +0.81%
==========================================
Files 337 338 +1
Lines 50514 50598 +84
==========================================
+ Hits 41131 41611 +480
+ Misses 9383 8987 -396 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some small comments, but this PR seems solid overall.
@hoxbro thanks for reviewing! I've pushed the changes as suggested. |
Thanks @thuydotm!! |
This MR adds DatetimeSlider widget, which is mentioned in #1972. The code is mainly based on Bokeh DateSlider model and the existing Panel DateSlider widget. Huge thanks to @hoxbro for your support!
TODO: