Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectors should inherit from Selector, not ObjectSelector #493

Closed
jbednar opened this issue Jun 27, 2021 · 0 comments · Fixed by #497
Closed

Selectors should inherit from Selector, not ObjectSelector #493

jbednar opened this issue Jun 27, 2021 · 0 comments · Fixed by #497
Labels
API Improvement to API or something like that
Milestone

Comments

@jbednar
Copy link
Member

jbednar commented Jun 27, 2021

ObjectSelector is old, deprecated API, replaced with Selector. However, FileSelector, ListSelector, and MultiFileSelector still inherit from ObjectSelector, making it difficult to remove and making those classes confusing to work with. Swapping ObjectSelector and Selector in the class hierarchy shouldn't affect anything not testing those exact classes, and we should do that soon to avoid future confusion.

@jbednar jbednar added the API Improvement to API or something like that label Jun 27, 2021
@jbednar jbednar added this to the v1.10.2 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Improvement to API or something like that
Projects
None yet
1 participant