Replace ObjectSelector with Selector #497
Conversation
|
Note that ListSelector, FileSelector, and MultiFileSelector all still use the convention from ObjectSelector where the first argument is the default value, not the objects list, and where the default value must be specified since it won't be computed from the objects list. Changing those things breaks backwards compatibility, so shouldn't be done lightly. |
|
Added a fix for #307 . |
| # existing objects, therefore instantiate is False by default. | ||
| def __init__(self, default=None, objects=None, instantiate=False, | ||
| def __init__(self, objects=None, default=None, instantiate=False, |
There was a problem hiding this comment.
This order is indeed better but in theory could break anyone passing in the arguments by position. This causing an issue is very unlikely in practice as I don't think I've ever seen that style of signature so overall I consider this an improvement.
|
Looks good! Sorry for not reviewing before merge but I don't see anything I would have objected to (other than a minor typo fix that I'll push a PR for now). |
Fixes #493