Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed various flake issues #301

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Fixed various flake issues #301

merged 2 commits into from
Nov 5, 2018

Conversation

philippjfr
Copy link
Member

The latest flake8 release seems to stricter about line breaks and escape sequences.

jbednar
jbednar approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see why it's complaining about some of those, but the old way and the new way both seem fine to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.713% when pulling e69dc80 on flake8_fixes into d175211 on master.

@philippjfr
Copy link
Member Author

I'll go ahead and merge so I can continue on the other PR.

@philippjfr philippjfr merged commit 34b14a7 into master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippjfr @coveralls @jbednar