Updated Selector to be a user friendly ObjectSelector #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
requested changes
Feb 19, 2019
There was a problem hiding this comment.
Looks good. I think it should be merged like this,, but in future we should consider flipping it around so that the bulk of the implementation is in Selector, not ObjectSelector, so that we could more clearly steer people to Selector and perhaps eventually deprecate ObjectSelector. But that's complicated by the classes that inherit from ObjectSelector, which would have to call super() in a different way due to the different constructor. So for the foreseeable future, we should probably just make sure our examples use Selector rather than ObjectSelector and leave it at that.
|
Note: The tests are currently failing due to issues submitting coverage reports to coveralls which is unrelated to this PR. |
jbednar
approved these changes
Feb 19, 2019
jbednar
reviewed
Feb 19, 2019
jbednar
approved these changes
Feb 19, 2019
Co-Authored-By: jlstevens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice and convenient in most cases with a shorter name. Addresses the second item listed in holoviz/datashader#698.