Ensure that param watch decorator is resolved using MRO #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Mar 15, 2019
| # TODO: should improve this - will happen for every | ||
| # instantiation of Parameterized with watched deps. Will | ||
| # probably store expanded deps on class - see metaclass | ||
| # 'dependers'. |
There was a problem hiding this comment.
Maybe I should look into these issues.
|
Looks good to me! The issue mentioned in the comment doesn't have to be addressed as part of this PR - I'm happy to merge once the tests pass. |
|
Tests have passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321