Fixed List validation #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
commented
Jun 28, 2021
| """ | ||
| Checks that the value is numeric and that it is within the hard | ||
| bounds; if not, an exception is raised. | ||
| """ |
There was a problem hiding this comment.
Oops; left a useless docstring in from where I copied this. I'll delete in a later PR.
jbednar
added a commit
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed validation for List parameters, which was broken in bf3d324 because the new
_validate_bounds()and_validate_item_type()methods weren't called by the default implementation of_validate(). Closes #491.