Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid escape sequence occurences #518

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix invalid escape sequence occurences #518

merged 2 commits into from
Sep 10, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Aug 19, 2021

As suggested in #423

jbednar
jbednar reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you have any idea what the ( and [ are for? I can't think of a reason those would have ever needed escaping in a Python string, and thus no reason to be forcing them to be raw strings.

tests/API0/testclassselector.py Show resolved Hide resolved
param/parameterized.py Show resolved Hide resolved
@holoviz holoviz deleted a comment from maximlt Aug 23, 2021
@holoviz holoviz deleted a comment from maximlt Aug 23, 2021
@holoviz holoviz deleted a comment from maximlt Aug 23, 2021
@holoviz holoviz deleted a comment from maximlt Aug 23, 2021
@jbednar jbednar merged commit ff2bbb2 into master Sep 10, 2021
@jbednar jbednar deleted the fix_invalid_escape_sequence branch September 10, 2021 22:34
@jbednar
Copy link
Member

jbednar commented Sep 10, 2021

Thanks! All looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar left review comments

@philippjfr philippjfr philippjfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximlt @jbednar @philippjfr