Update supported Python versions and add a badge in the README #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would get 2.7 out. It could signal that Param is legacy, out of date or no longer actively supported. I.e. give a wrong signal. |
|
Param is a foundational library and thus should be more open in version support than just about any other library. But like Python 2.7 itself, I think that concern only applies to Param 1.x, which should continue to be usable with Python 2.7 indefinitely. Once we switch to Param 2.x I don't see any reason to provide Python 2.7 support any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python versions supported by param are reflected by those currently tested in the CI, i.e. 2.7, 3.6, 3.7, 3.8 and 3.9. This PR updates setup.py to list these versions. Note that Python 3.10 will be out soon and it'd be nice to add it to the CI and see how that goes.
This PR also adds a badge to the README that shows the Python versions supported by param. Since param is meant to be a foundational library of its kind, it's nice to show that it is compatible with many versions of Python. This badge could also be added to the landing page of the site if required.