Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListSelector restricted to list type objects #531

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Sep 20, 2021

Fixes #527

I chose to raise a ValueError when the type is not a list since raising ValueError seems to be what param does in this case. The tests used to catch TypeErrors in some occasions because param was trying to iterate over non iterables.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@f87fa8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #531   +/-   ##
=========================================
  Coverage          ?   82.12%           
=========================================
  Files             ?        4           
  Lines             ?     2954           
  Branches          ?        0           
=========================================
  Hits              ?     2426           
  Misses            ?      528           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87fa8c...5e725e6. Read the comment docs.

@droumis droumis added this to the v1.12.x milestone Jan 16, 2023
@philippjfr
Copy link
Member

We need to be consistent about ValueError and TypeError but in this case this is more consistent because it matches what param.List raises when given the wrong type.

@philippjfr philippjfr merged commit a9ec25b into main Jan 16, 2023
@philippjfr philippjfr deleted the fix_listselector branch January 16, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListSelector doesn't check the type
4 participants