Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build #537

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Fix conda build #537

merged 3 commits into from
Oct 2, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 2, 2021

nose was still expected by conda build to run the test suite, which couldn't work at all since it was replaced recently by pytest.

Part of this PR I've also decided to move the last doctest (param.Time) to a unit test. Why? Because conda build failed by simply replacing nosetests tests by pytest tests. It executes this from a folder that only includes the subfolder tests, and the command that was set to tell pytest to look for doctest to execute required the subfolders param and numberben to be also there (pytest tests param numbergen --doc-modules).

There may have been a way to configure pytest to cover this case but I thought it was just simpler to remove that last doctest. This makes even more sense now since param has some nice docs :)

Note that I've not removed the docstest code from the docstring, since it is still useful docs in itself. It's just no longer executed by pytest.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

conda.recipe/meta.yaml Outdated Show resolved Hide resolved
tests/API1/testtimedependent.py Outdated Show resolved Hide resolved
@jbednar jbednar merged commit 9682909 into master Oct 2, 2021
@jbednar jbednar deleted the fix_conda_build branch October 2, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants