Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binder #564

Merged
merged 6 commits into from
Oct 29, 2021
Merged

Fix binder #564

merged 6 commits into from
Oct 29, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 28, 2021

The env created by Binder didn't include any of the declared dependencies.

Edit:
This is now fixed, and binder relies on the version of param that is on master.

@maximlt maximlt marked this pull request as draft October 28, 2021 08:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #564 (27abb6d) into master (a10fe2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files           4        4           
  Lines        2991     2991           
=======================================
  Hits         2457     2457           
  Misses        534      534           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10fe2b...27abb6d. Read the comment docs.

@maximlt maximlt marked this pull request as ready for review October 28, 2021 09:04
@maximlt maximlt merged commit 925173c into master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants