Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at whole spec name when determining dynamic watchers #615

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 11, 2022

Fixes #614

TODO:

  • Needs to add a unit test

@philippjfr
Copy link
Member

Thanks! Happy to merge but a unit test would indeed be nice.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #615 (756ada2) into master (331e817) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files           4        4           
  Lines        3027     3027           
=======================================
  Hits         2476     2476           
  Misses        551      551           
Impacted Files Coverage Δ
param/parameterized.py 81.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331e817...756ada2. Read the comment docs.

@hoxbro
Copy link
Member Author

hoxbro commented Apr 11, 2022

I'm not sure if it is the right place I added the unit test. I will move it if needed.

@philippjfr philippjfr merged commit afbe552 into holoviz:master Apr 11, 2022
@hoxbro hoxbro deleted the fix_depends_sensitive branch April 11, 2022 12:20
@jbednar jbednar changed the title Look at whole spec name when determing dynamic watchers Look at whole spec name when determining dynamic watchers Apr 11, 2022
@jbednar
Copy link
Member

jbednar commented Apr 11, 2022

Thanks! That looks like just the right fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depends is sensitive to widget name
4 participants