Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure async functionality does not cause python2 syntax errors #624

Merged
merged 7 commits into from
May 16, 2022

Conversation

philippjfr
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #624 (9f2f037) into master (b78f700) will increase coverage by 1.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   81.79%   82.81%   +1.01%     
==========================================
  Files           4        5       +1     
  Lines        3027     3037      +10     
==========================================
+ Hits         2476     2515      +39     
+ Misses        551      522      -29     
Impacted Files Coverage Δ
param/_async.py 100.00% <100.00%> (ø)
param/parameterized.py 83.32% <100.00%> (+1.43%) ⬆️
numbergen/__init__.py 80.32% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78f700...9f2f037. Read the comment docs.

@maximlt
Copy link
Member

maximlt commented May 12, 2022

This looks good to me. I'll try to add some tests because I think these code paths aren't tested at all.

@maximlt
Copy link
Member

maximlt commented May 16, 2022

@philippjfr this is ready to me, the tests I've added are really simple and are just meant to get 100% coverage of the _async module.

@philippjfr philippjfr merged commit b38d3b4 into master May 16, 2022
@philippjfr philippjfr deleted the py2_compat branch May 16, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants