Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff D rule #982

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add Ruff D rule #982

merged 4 commits into from
Dec 4, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Nov 23, 2024

Builds on #977. So review that one first.

The only thing I've touched is in pyproject.toml. The rest is auto fixed by Ruff when I run ruff check.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (b52fde8) to head (ea395f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
param/serializer.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files           9        9           
  Lines        4928     4928           
=======================================
  Hits         4304     4304           
  Misses        624      624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the base branch from main to enhancement/rx-docs November 23, 2024 08:14
@hoxbro
Copy link
Member

hoxbro commented Nov 23, 2024

Just changing base branch so it easier to review

param/serializer.py Show resolved Hide resolved
tests/utils.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Base automatically changed from enhancement/rx-docs to main December 4, 2024 14:27
@maximlt maximlt force-pushed the enhancement/ruff-D-rule branch from 7af55fb to 622fd4a Compare December 4, 2024 14:46
@maximlt maximlt merged commit 0d73ff5 into main Dec 4, 2024
16 checks passed
@maximlt maximlt deleted the enhancement/ruff-D-rule branch December 4, 2024 15:09
@maximlt maximlt restored the enhancement/ruff-D-rule branch December 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants