-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruff D rule #982
Merged
Merged
Add Ruff D rule #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcSkovMadsen
commented
Nov 23, 2024
MarcSkovMadsen
commented
Nov 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 9 9
Lines 4928 4928
=======================================
Hits 4304 4304
Misses 624 624 ☔ View full report in Codecov by Sentry. |
Merged
Just changing base branch so it easier to review |
hoxbro
approved these changes
Nov 23, 2024
hoxbro
approved these changes
Nov 23, 2024
maximlt
approved these changes
Nov 25, 2024
maximlt
force-pushed
the
enhancement/ruff-D-rule
branch
from
December 4, 2024 14:46
7af55fb
to
622fd4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #977. So review that one first.
The only thing I've touched is in pyproject.toml. The rest is auto fixed by Ruff when I run
ruff check
.