Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for GAP to 0.9, (keep existing compat) #58

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 2, 2022

This pull request changes the compat entry for the GAP package from 0.7, 0.8 to 0.7, 0.8, 0.9.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@zickgraf
Copy link
Member

@mohamed-barakat GAP 0.8(.5) seems to be incompatible with the latest Julia nightly. So depending on GAP <= 0.8 prevents us from using an up-to-date stack. Are there any concerns/problems with using GAP 0.9?

@zickgraf
Copy link
Member

I just checked: With the following versions the tests of the notebooks of FinSetsForCAP and FunctorCategories succeed:

  • Julia 1.10.0-DEV
  • IJulia 1.24.0
  • GAP 0.9.2
  • CapAndHomalg 1.4.7

@mohamed-barakat
Copy link
Member

I will merge this after merging #60.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 48.43% // Head: 48.43% // No change to project coverage 👍

Coverage data is based on head (8da2806) compared to base (8da2806).
Patch has no changes to coverable lines.

❗ Current head 8da2806 differs from pull request most recent head f8ad699. Consider uploading reports for the commit f8ad699 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   48.43%   48.43%           
=======================================
  Files           3        3           
  Lines         128      128           
=======================================
  Hits           62       62           
  Misses         66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mohamed-barakat
Copy link
Member

mohamed-barakat commented Jan 17, 2023

Tests / Julia 1.7 - ubuntu-latest - x64 (pull_request):

Digraphs: Error During Test at /home/runner/work/CapAndHomalg.jl/CapAndHomalg.jl/test/digraphs.jl:1
  Got exception outside of a @test
  Error thrown by GAP: Error, LOAD_DYN: failed to load kernel module /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/bin/x86_64-pc-linux-gnu-julia1.7-64-kv8/digraphs.so, /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/bin/x86_64-pc-linux-gnu-julia1.7-64-kv8/digraphs.so: undefined symbol: LenListFuncs in
    LOAD_DYN( filename ) at /home/runner/.julia/artifacts/b5c2f0f824457e5c391fb24916f94d5d91c62c4f/share/gap/lib/files.gd:592 called from 
  <function "LoadDynamicModule">( <arguments> )
   called from read-eval loop at /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/init.g:24

@zickgraf
Copy link
Member

I have opened an issue in the issue tracker of GAP.jl: oscar-system/GAP.jl#851

@zickgraf
Copy link
Member

zickgraf commented Feb 3, 2023

The issue with Digraphs is fixed in GAP.jl 🎉 So after the next release of GAP.jl we should be able to update to GAP.jl 0.9(.3).

@mohamed-barakat
Copy link
Member

Excellent.

@zickgraf zickgraf force-pushed the compathelper/new_version/2022-11-02-02-20-19-428-03152217187 branch from 8644e51 to 2eac11d Compare February 6, 2023 07:54
@zickgraf zickgraf force-pushed the compathelper/new_version/2022-11-02-02-20-19-428-03152217187 branch from 2eac11d to f8ad699 Compare February 6, 2023 07:55
@zickgraf
Copy link
Member

zickgraf commented Feb 6, 2023

The CI is now green 🎉 (up to a deadlock in Julia nightly on macOS which is better than not running on nightly at all).

@mohamed-barakat
Copy link
Member

Wonderful, thank you very much.

@mohamed-barakat mohamed-barakat merged commit 24ff8f7 into master Feb 6, 2023
@zickgraf zickgraf deleted the compathelper/new_version/2022-11-02-02-20-19-428-03152217187 branch February 6, 2023 09:18
mohamed-barakat added a commit to mohamed-barakat/HomalgProject.jl that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants