-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for GAP to 0.9, (keep existing compat) #58
CompatHelper: bump compat for GAP to 0.9, (keep existing compat) #58
Conversation
@mohamed-barakat GAP 0.8(.5) seems to be incompatible with the latest Julia nightly. So depending on GAP <= 0.8 prevents us from using an up-to-date stack. Are there any concerns/problems with using GAP 0.9? |
I just checked: With the following versions the tests of the notebooks of FinSetsForCAP and FunctorCategories succeed:
|
I will merge this after merging #60. |
Codecov ReportBase: 48.43% // Head: 48.43% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 48.43% 48.43%
=======================================
Files 3 3
Lines 128 128
=======================================
Hits 62 62
Misses 66 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Tests / Julia 1.7 - ubuntu-latest - x64 (pull_request): Digraphs: Error During Test at /home/runner/work/CapAndHomalg.jl/CapAndHomalg.jl/test/digraphs.jl:1
Got exception outside of a @test
Error thrown by GAP: Error, LOAD_DYN: failed to load kernel module /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/bin/x86_64-pc-linux-gnu-julia1.7-64-kv8/digraphs.so, /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/bin/x86_64-pc-linux-gnu-julia1.7-64-kv8/digraphs.so: undefined symbol: LenListFuncs in
LOAD_DYN( filename ) at /home/runner/.julia/artifacts/b5c2f0f824457e5c391fb24916f94d5d91c62c4f/share/gap/lib/files.gd:592 called from
<function "LoadDynamicModule">( <arguments> )
called from read-eval loop at /home/runner/.julia/gaproot/v4.12/pkg/digraphs-1.6.1/init.g:24 |
I have opened an issue in the issue tracker of GAP.jl: oscar-system/GAP.jl#851 |
The issue with Digraphs is fixed in GAP.jl 🎉 So after the next release of GAP.jl we should be able to update to GAP.jl 0.9(.3). |
Excellent. |
8644e51
to
2eac11d
Compare
2eac11d
to
f8ad699
Compare
The CI is now green 🎉 (up to a deadlock in Julia nightly on macOS which is better than not running on nightly at all). |
Wonderful, thank you very much. |
This pull request changes the compat entry for the
GAP
package from0.7, 0.8
to0.7, 0.8, 0.9
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.