This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Added support for HF-LPB100 chip based device discovery #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I am in the process of adding a new component to Home Assistant for the Sunix LED Strip Controller based on this library: sunix-ledstrip-controller-client.
Since this controller uses the HF-LPB100 WiFi chip which supports discovery and I want to make it as easy as possible for Home Assistant users to use this component I want to use the discovery feature to automatically add entities found on the local network to Home Assistant.
There is a problem though that I am not quite sure on how to tackle:
The discovery protocol implemented on the HF-LPB100 chip is used by a variety of devices and at least on my LED controller the discovery does not include any information on what kind of device this actually is. The data delivered is similar to this:
I am not sure if this response data is always the same on every device using this chip but even if it were I simply cant tell if the device that is detected is an RGBWWCW controller compatible with my library or something totally different. The only way I can think of to "fix" this is by discovering those devices and let the Home Assistant admin/user decide what component implementation should be used for this discovered device after it has been discovered in the frontend. Would this even be possible and desirable?
Thanks for your time,
Markus
PS: The code added in this PR is mostly c&p from the mentioned library (which I own so there is no problem in that) to minimize the impact.