Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

Added support for HF-LPB100 chip based device discovery #226

Closed
wants to merge 2 commits into from
Closed

Added support for HF-LPB100 chip based device discovery #226

wants to merge 2 commits into from

Conversation

markusressel
Copy link

Hi there,

I am in the process of adding a new component to Home Assistant for the Sunix LED Strip Controller based on this library: sunix-ledstrip-controller-client.

Since this controller uses the HF-LPB100 WiFi chip which supports discovery and I want to make it as easy as possible for Home Assistant users to use this component I want to use the discovery feature to automatically add entities found on the local network to Home Assistant.

There is a problem though that I am not quite sure on how to tackle:
The discovery protocol implemented on the HF-LPB100 chip is used by a variety of devices and at least on my LED controller the discovery does not include any information on what kind of device this actually is. The data delivered is similar to this:

Found new service: hf_lpb100 {'host': '192.168.0.123', 'serial': 'A0BD6667C9A0', 'model_name': 'HF-LPB100-ZJ200'}

I am not sure if this response data is always the same on every device using this chip but even if it were I simply cant tell if the device that is detected is an RGBWWCW controller compatible with my library or something totally different. The only way I can think of to "fix" this is by discovering those devices and let the Home Assistant admin/user decide what component implementation should be used for this discovered device after it has been discovered in the frontend. Would this even be possible and desirable?

Thanks for your time,
Markus

PS: The code added in this PR is mostly c&p from the mentioned library (which I own so there is no problem in that) to minimize the impact.

added specific implementation for sunix devices
@homeassistant
Copy link

Hi @markusressel,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob
Copy link
Collaborator

balloob commented Dec 14, 2018

At this point in time I don't want to add any more proprietary discovery protocols to netdisco, as I am considering removing the other proprietary ones too.

If you want to make it easy for users in Home Assistant, implement a config entry. Once user clicks Configure Sunix, it can find them and set it up.

@balloob balloob closed this Dec 14, 2018
@markusressel
Copy link
Author

And... whats the reasoning behind this?

@balloob
Copy link
Collaborator

balloob commented Dec 17, 2018

#230

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants