Bump to OkHttp 5 #4023
Merged
Bump to OkHttp 5 #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
yschimke
commented
Nov 22, 2023
common/src/main/java/io/homeassistant/companion/android/common/data/HomeAssistantApis.kt
Outdated
Show resolved
Hide resolved
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
Looks like there are new releases on the 5.0 branch again (when the PR was submitted, it had almost been a year since a release), and they put the same note about 'stable except for new APIs' in the docs. I don't see any reason to not accept this PR if it is rebased/updated/building is fixed. |
jpelgrom
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use OkHttp5, while alpha it is production quality, but new API are not stable.
But critically it includes support for a simplified form of Happy Eyeballs, avoiding issues on IPv6 networks.
See https://www.reddit.com/r/RedditEng/comments/v1upr8/ipv6_support_on_android/
No offense if this is too soon. Please close the PR if so.
Screenshots
N/A
Link to pull request in Documentation repository
N/A
Any other notes
N/A