Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless time fetch in DataUpdateCoordinator #107999

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 14, 2024

Proposed change

Since we used the async_call_at helper, it would always call dt_util.utcnow() to feed the _handle_refresh_interval which threw it away. This meant we had to fetch time twice as much as needed for each update.

We spent a lot of effort in the past to reduce the amount of time calls because there are ARM platforms with errata which can't use vdso. On these platforms time calls are about an order of magnitude slower because time calls are full syscalls (which includes the Blue)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Since we used the async_call_at helper, it would always call dt_util.utcnow()
to feed the _handle_refresh_interval which threw it away. This meant we had
to fetch time twice as much as needed for each update
@bdraco bdraco marked this pull request as ready for review January 14, 2024 03:17
@bdraco bdraco requested a review from a team as a code owner January 14, 2024 03:17
@balloob balloob merged commit 8d3f693 into dev Jan 14, 2024
50 checks passed
@balloob balloob deleted the duc_useless_time branch January 14, 2024 04:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants