Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruff to 0.6.0 #123985

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Bump ruff to 0.6.0 #123985

merged 2 commits into from
Aug 16, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Aug 15, 2024

Proposed change

Bump ruff to 0.6.0
https://github.com/astral-sh/ruff/releases/tag/0.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed dependency small-pr PRs with less than 30 lines. labels Aug 15, 2024
@joostlek joostlek marked this pull request as ready for review August 15, 2024 13:14
@joostlek joostlek requested a review from a team as a code owner August 15, 2024 13:14
@autinerd
Copy link
Contributor

Ah, you were faster than me 😄
Please change pyproject.toml to >=0.6.0 because of new occurrences

@joostlek
Copy link
Member Author

Honestly, I'd only do that with big changes, I don't expect everyone to make ElementTrees now all of a sudden.

Curious what others think

@frenck
Copy link
Member

frenck commented Aug 16, 2024

I think it ain't a big issue. pre-commit will catch it, otherwise CI will.

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 06209dd into home-assistant:dev Aug 16, 2024
39 of 40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants