Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description placeholder in brunt reauth #128933

Merged

Conversation

rappenze
Copy link
Contributor

Proposed change

Add name placeholder which is used in the reauth dialog title.

Referenced by "title": "[%key:common::config_flow::title::reauth%]" and resolved to "reauth": "Authentication expired for {name}".

Detected and already fixed in the fibaro integration by #128925.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration (brunt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of brunt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign brunt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rappenze rappenze marked this pull request as ready for review October 21, 2024 18:48
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing

homeassistant/components/brunt/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/brunt/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 21, 2024 18:50
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@rappenze
Copy link
Contributor Author

@gjohansson-ST: Looks like we have the same problem in some more integrations. Hard to find the affected integrations, do you have an idea how to find them?

@gjohansson-ST
Copy link
Member

@gjohansson-ST: Looks like we have the same problem in some more integrations. Hard to find the affected integrations, do you have an idea how to find them?

Search for [%key:common::config_flow::title::reauth%] in the code base (in respective integrations strings.json)

@rappenze rappenze marked this pull request as ready for review October 21, 2024 18:54
@home-assistant home-assistant bot requested a review from jpbede October 21, 2024 18:54
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jpbede jpbede merged commit 63582bb into home-assistant:dev Oct 21, 2024
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@rappenze rappenze deleted the fix_description_placeholder_in_brunt_reauth branch February 8, 2025 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants