Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove battery device class from bmw secondary sensor #128970

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Remove battery device class from bmw secondary sensor #128970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion homeassistant/components/bmw_connected_drive/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class BMWSensorEntityDescription(SensorEntityDescription):
BMWSensorEntityDescription(
key="fuel_and_battery.charging_target",
translation_key="charging_target",
device_class=SensorDeviceClass.BATTERY,
zweckj marked this conversation as resolved.
Show resolved Hide resolved
native_unit_of_measurement=PERCENTAGE,
suggested_display_precision=0,
is_available=lambda v: v.is_lsc_enabled and v.has_electric_drivetrain,
Expand Down
9 changes: 3 additions & 6 deletions tests/components/bmw_connected_drive/snapshots/test_sensor.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
'suggested_display_precision': 0,
}),
}),
'original_device_class': <SensorDeviceClass.BATTERY: 'battery'>,
'original_device_class': None,
'original_icon': None,
'original_name': 'Charging target',
'platform': 'bmw_connected_drive',
Expand All @@ -259,7 +259,6 @@
# name: test_entity_state_attrs[sensor.i3_rex_charging_target-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'battery',
'friendly_name': 'i3 (+ REX) Charging target',
'unit_of_measurement': '%',
}),
Expand Down Expand Up @@ -894,7 +893,7 @@
'suggested_display_precision': 0,
}),
}),
'original_device_class': <SensorDeviceClass.BATTERY: 'battery'>,
'original_device_class': None,
'original_icon': None,
'original_name': 'Charging target',
'platform': 'bmw_connected_drive',
Expand All @@ -908,7 +907,6 @@
# name: test_entity_state_attrs[sensor.i4_edrive40_charging_target-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'battery',
'friendly_name': 'i4 eDrive40 Charging target',
'unit_of_measurement': '%',
}),
Expand Down Expand Up @@ -1900,7 +1898,7 @@
'suggested_display_precision': 0,
}),
}),
'original_device_class': <SensorDeviceClass.BATTERY: 'battery'>,
'original_device_class': None,
'original_icon': None,
'original_name': 'Charging target',
'platform': 'bmw_connected_drive',
Expand All @@ -1914,7 +1912,6 @@
# name: test_entity_state_attrs[sensor.ix_xdrive50_charging_target-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'battery',
'friendly_name': 'iX xDrive50 Charging target',
'unit_of_measurement': '%',
}),
Expand Down
Loading