Tado change to async and add Data Update Coordinator #134175
Draft
+952
−720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
requested changes
Jan 1, 2025
tests/components/tado/test_helper.py
Outdated
| @@ -13,15 +13,17 @@ | |||
| from homeassistant.core import HomeAssistant | |||
|
|
|||
|
|
|||
| def dummy_tado_connector(hass: HomeAssistant, fallback) -> TadoConnector: | |||
| def dummy_tado_connector(hass: HomeAssistant, fallback) -> TadoDataUpdateCoordinator: | |||
There was a problem hiding this comment.
I think in this case it would be nice if we can remove these tests soon
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
requested changes
Jan 9, 2025
| except Exception as err: | ||
| raise UpdateFailed(f"Error updating Tado data: {err}") from err | ||
|
|
||
| return self.data |
There was a problem hiding this comment.
Make the update function return pieces of data and put them together in the _async_update_data function to return
Co-authored-by: Joost Lekkerkerker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Upgrading the Tado integration to go with the better variant to utilize the Data Update Coordinator. In the same time, the synchronous calls have all been wrapped in the
async_add_executor_joband to make the Coordinator use async.TODO:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: