Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded vesync device base class #134499

Merged
merged 7 commits into from
Jan 5, 2025

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented Jan 2, 2025

Proposed change

This entity is used in select spots where other platforms aren't. However this creates more of a challenge as we add items. Quick example switches use it but it isn't correct for items like "Screen on control" which we will add for humidifiers. I believe easier to place it where it is expected and keep the base entity on items that are universal.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdnninja
Copy link
Contributor Author

cdnninja commented Jan 2, 2025

@iprak

@epenet epenet changed the title Remove unneeded vesync device class Remove unneeded vesync device base class Jan 3, 2025
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove all these details properties as they are unused.

Also, while you are improving the code, can you also do a pass to add typing to everything? That massively helps reviewing :D

homeassistant/components/vesync/fan.py Outdated Show resolved Hide resolved
homeassistant/components/vesync/light.py Outdated Show resolved Hide resolved
homeassistant/components/vesync/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 3, 2025 11:01
@home-assistant
Copy link

home-assistant bot commented Jan 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdnninja
Copy link
Contributor Author

cdnninja commented Jan 4, 2025

Typing added in a few key spots. I will keep adding if I run into other spots with it missing.

@cdnninja cdnninja marked this pull request as ready for review January 4, 2025 00:45
@home-assistant home-assistant bot requested a review from joostlek January 4, 2025 00:45
@cdnninja cdnninja mentioned this pull request Jan 4, 2025
19 tasks
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing improvements look good, just one small suggestion.

homeassistant/components/vesync/common.py Outdated Show resolved Hide resolved
@allenporter allenporter dismissed joostlek’s stale review January 5, 2025 17:18

Feedback was addressed

@allenporter allenporter merged commit d662a44 into home-assistant:dev Jan 5, 2025
33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants