Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework velbus services to deprecated the interface parameter #134816

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

cereal2nd
Copy link
Contributor

@cereal2nd cereal2nd commented Jan 5, 2025

Proposed change

Currently the velbus services use a interface parameter, this is a simple string that should be exactly the same as the config_entry parameter.

With this PR i'm deprecating this interface parameter and adding a new parameter that uses a config_entry selector, this is more user-friendly.

The interface parameter is deprecated and will be remover in the 2025.9 release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 5, 2025

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velbus can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velbus Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/velbus/services.py Outdated Show resolved Hide resolved
homeassistant/components/velbus/services.py Outdated Show resolved Hide resolved
homeassistant/components/velbus/services.py Outdated Show resolved Hide resolved
homeassistant/components/velbus/services.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Jan 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 6, 2025 13:51
@cereal2nd cereal2nd marked this pull request as ready for review January 6, 2025 15:25
@home-assistant home-assistant bot requested a review from joostlek January 6, 2025 15:25
@cereal2nd cereal2nd marked this pull request as draft January 6, 2025 16:08
@cereal2nd cereal2nd marked this pull request as ready for review January 6, 2025 16:25
homeassistant/components/velbus/services.py Show resolved Hide resolved
tests/components/velbus/test_services.py Show resolved Hide resolved
tests/components/velbus/test_services.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 09:51
@cereal2nd cereal2nd marked this pull request as ready for review January 10, 2025 11:49
@home-assistant home-assistant bot requested a review from joostlek January 10, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Velbus] Set_memo_text not working in HA 2025.1
2 participants