Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token before setting up weheat #135264

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jesperraemaekers
Copy link
Contributor

Proposed change

On integration setup, refresh the oath token.
We've had some instances of needing to re-authenticate after (for example) updating HA as then the access token has expired. Taking this trick from integrations as Spotify and Google sheets to refresh the token first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 08:44
@jesperraemaekers jesperraemaekers marked this pull request as ready for review January 10, 2025 09:19
@home-assistant home-assistant bot requested a review from joostlek January 10, 2025 09:19
tests/components/weheat/test_init.py Outdated Show resolved Hide resolved
tests/components/weheat/test_init.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 10:08
@jesperraemaekers jesperraemaekers marked this pull request as ready for review January 10, 2025 13:00
@home-assistant home-assistant bot requested a review from joostlek January 10, 2025 13:00
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joostlek joostlek merged commit 6fd9476 into home-assistant:dev Jan 13, 2025
34 checks passed
dotvav pushed a commit to dotvav/home-assistant-core that referenced this pull request Jan 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants