Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palazzetti Quality Scale update after doc improvement #135277

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

dotvav
Copy link
Contributor

@dotvav dotvav commented Jan 10, 2025

Proposed change

Update of the quality scale for the Palazzetti integration after the recent doc improvement.

Link to the integration doc PR:
home-assistant/home-assistant.io#36599 (comment)

Link to the integration doc page:
https://www.home-assistant.io/integrations/palazzetti/

QS Changes:
docs-installation-instructions: done
docs-installation-parameters: done
docs-examples: done
docs-known-limitations: done
docs-troubleshooting: done
docs-use-cases: done

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@dotvav dotvav changed the title QS update after doc improvement Palazzetti Quality Scale update after doc improvement Jan 10, 2025
@dotvav dotvav marked this pull request as ready for review January 10, 2025 09:52
docs-installation-instructions: todo
docs-removal-instructions: todo
docs-installation-instructions: done
docs-removal-instructions: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one appears to be missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct

@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 17:24
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dotvav dotvav marked this pull request as ready for review January 11, 2025 12:19
@home-assistant home-assistant bot requested a review from zweckj January 11, 2025 12:19
@zweckj zweckj merged commit 4cf7a51 into home-assistant:dev Jan 11, 2025
34 checks passed
@dotvav dotvav deleted the palazzetti_quality_scale branch January 11, 2025 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants