-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce wiz_light integration for WiZ bulbs #35132
Conversation
As a happy use of this integration, there’s an unfortunately incompatibility with the HASS homekit integration. HASS Homekit was recently changed to send RGB values for color temperatures. The wiz bulbs, however, are extremely limited in brightness when provided with RGB values compared to Kelvins. This makes it impossible to set the bulbs to any reasonable brightness after selecting a color in the HASS homekit integration. You can see this in behavior in the HASS UI as well - the RGB “white” is significantly dimmer than the Kelvin “white” Please let me know if should be reporting this somewhere else, wasn’t sure where to put it because it involves the core itself |
Thanks for the feedback on this. 👍 I think there a two main points:
In my opinion this can be a general problem from the HA core because there should be a standard for the color temperature definition (kelvin or mired or RGB). If this standard unit will become/is RGB I can change my code and integrate a RGB-to-Kelvin function. I'll prefer to stay with Kelvin because it is a well defined standard unit. Maybe @frenck can give us/me some more details/insights about the Kelvin-or-RGB discussion. 😉 Thank you again - I'll update the documentation in the wiz_light with the issue by integrations with homekit. 😄 |
Thanks for putting this together! I'm testing it out and it seems to be working well, though the logs are showing an unhandled error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @sbidy! Thanks for the PR!
This integration is communicating with a device, and thus need to be implemented with a configuration flow via the frontend.
See: https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md
Developer information can be found here: https://developers.home-assistant.io/docs/config_entries_config_flow_handler#defining-your-config-flow
We have a scaffolding tool available to help out with this transition: python3 -m script.scaffold integration
Thanks!
@frenck thanks for the feedback. I'll update the pull with the config flow version soon. This update will also include a unique device ID for each bulb. @michaeldavie in this case you have a bulb which doesn't support this function. The integration tries to idetifiv the bulb and the available functions. In some cases the bulb reports a invalid or unknown device type. Can you pleas provide your bulb type, vendor and maybe the device ID? Please also look into the wiz_light repo here on GitHub for more info. |
Thanks, I've opened sbidy/wiz_light#26 to track this issue. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Any updates on this? I have a few WiZ bulbs and would love for this to move forward. :) |
I'm using the code from https://github.com/sbidy/wiz_light as a custom component and it's working quite well. |
@michaeldavie thanks! I was able to get it installed as a custom component and it is working beautifully! I look forward to this PR being accepted. 😁 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
I hope this component will be part of hassio. I am using it without any problem as custom component. |
I try to bring in the required ConfigFlow thing but currently I've not enough time for test and implementation. I'm looking forward to solve that dependency in the next weeks. Contributions are wellcomen :-) |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Looks like this was auto-closed... Hoping this gets re-opened and moves forward. :) |
Love the four Color Hue br30s we already have. Bought one wiz color br30 to compare quality. Was pleasantly surprised that brightness and color are more similar than I expected given the price difference. Was about to pull the trigger on buying 40 more wiz color br30s, but got cold feet seeing this went stale. A status update would be great!! |
Work in progress 😉 |
Thanks, @sbidy! I have the Philips Smart Wi-Fi LED light strip with WiZ with which I can help test. |
This is somthing I need too! |
The new pull is online - #44522 |
Proposed change
A HA integration for WiZ Light bulbs (Phillips, SLV and more). The integration extents HA to communicate directly with this WiFi connected lights via async UDP calls. There is no Cloud or Web API needed for interaction with this lights.
The integration is designed async, including the UDP calls via pywizlight extension.
Supported Features:
wiz_light GitHub // pywizlight
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: