Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New configuration flow for ZHA integration #35161
New configuration flow for ZHA integration #35161
Changes from 20 commits
4f5f5c9
3a7475f
0183b26
43f6225
6804291
e7b8cad
e4a0552
0c5ac74
0a8a072
708cefb
a6c258f
662c074
546f411
ccecfa3
fe377f0
0592f83
69fbade
a0a733a
ac0c03f
1b425b5
3101046
10d8aae
c5a3757
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data attribute should be considered read only. We set it to a mapping proxy when the config entry is defined. We should use
hass.config_entries.async_update_entry
to update the data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll update it.
BTW this was copied that from
axis
integration, so that may need update too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it's using
async_update_entry()
now. For config entry migration, i still have to set theconfig_entry.version
attribute to the new version, right?