Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update influxdb dependency to 5.3.1 #62228

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Dec 17, 2021

Proposed change

Update influxDB dependency from 5.2.3 to 5.3.1. Contains primarily bug fixes and small QOL improvements. Changelog can be found here.

Note: The changelog says that 5.3.1 is unreleased but it is available in pip. I'm not entirely sure what to make of that. It's not a dev build since there have been commits to the repo since then. I think the author may have forgotten to modify the changelog after releasing it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (influxdb) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@mdegat01 mdegat01 changed the title Update influxdb dependency to 5.3.0 Update influxdb dependency to 5.3.1 Dec 17, 2021
@MartinHjelmare
Copy link
Member

There's no tag for 5.3.1. Maybe open an issue and ask them to make a tag and update the changelog?

https://github.com/influxdata/influxdb-python/tags

@mdegat01
Copy link
Contributor Author

Looks like there is one already and its not new: influxdata/influxdb-python#887 .

I think this project is essentially in maintenance mode since it only works for 1.x and Influx's attention is entirely on 2.0 now. I'll bump the issue but we may not get anything, I'm not sure when/if there will be another release barring a security issue. I can revert to 5.3.0 if we want although I was hoping 5.3.1 would fix the linked issue, 5.3.0 definitely won't.

@MartinHjelmare
Copy link
Member

This commit range matches the release date of 5.3.1 on PyPI:
influxdata/influxdb-python@v5.2.3...7b03673

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 4, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK to move forward with, looking at the changelog and the link @MartinHjelmare posted.

Would you agree @MartinHjelmare ?

@MartinHjelmare
Copy link
Member

Yes. 👍

@frenck frenck merged commit 8d2cb82 into home-assistant:dev Jan 4, 2022
jeeftor pushed a commit to jeeftor/core that referenced this pull request Jan 4, 2022
@mdegat01 mdegat01 deleted the update-influxdb-dep branch January 4, 2022 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed core dependency integration: influxdb integration: sensor small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants