Fix failure to raise on bad YAML syntax from include files #75510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The test was mocking out the underlying object so it came in as StringIO instead of TextIOWrapper. To resolve this another test was added that uses an actual file on disk so we have a better end to end test
Closed
frenck
requested changes
Jul 20, 2022
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
|
The linter is trying to hard here. I ended up renaming it to .yaml.txt to side step that since its never going to be valid |
|
That will do as well I guess 🤷 |
frenck
approved these changes
Jul 20, 2022
frenck
added a commit
that referenced
this pull request
Jul 20, 2022
Co-authored-by: Franck Nijhof <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the CI is failing because the test fixture has bad yaml. We want to keep that
Proposed change
came in as StringIO instead of TextIOWrapper. To resolve
this another test was added that uses an actual file
on disk so we have a better end to end test
Fixes #75374 Fixes #74806 Fixes #75006 Fixes #75070
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: