-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump onvif-zeep-async to 1.2.11 #91472
Conversation
reverts a change to the wsdl document creation that broke tplink c100s changelog: openvideolibs/python-onvif-zeep-async@v1.2.7...v1.2.8
Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I think I can iterate on this one more time and make it simpler Will do another pass after lunch |
No reason to not merge this though as it can happen in another pass and the fixes are still good here |
I'm going to do the revert for now and than work through the I/O in the event loop in another PR |
Still working on the I/O |
|
The reason the other fix can't move forward yet is because its actually relying on the event loop being blocked for a moment since we don't have mvantellingen/python-zeep#1369 Otherwise we ask too quickly if the camera supports events and sometimes we don't get a reply in time. 🤦 |
so its flakey with every version because sometimes creating a subscription has transient failures 😢 |
So lets do the bump to 1.2.10 and see if we can make event startup more reliable in another PR |
The reason it was flakey was the old subscriptions were never being removed because of #91482 |
So the reason its flakey is most cameras only allow 3 subscriptions and we set the subscription time to 24 hours. If you restart 3 times you run out of slots and have to wait for a free one. #91485 will adjust that to resub every 5 minutes so we don't ever run out of slots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button
Proposed change
reverts a change to the wsdl document creation that broke tplink c110s and fixes more I/O in the event loop
sets a minimum version of zeep to ensure upstream fixes are included
changelog: openvideolibs/python-onvif-zeep-async@v1.2.7...v1.2.11
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: