Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transmission error handling #91548

Merged
merged 6 commits into from
May 5, 2023
Merged

Fix transmission error handling #91548

merged 6 commits into from
May 5, 2023

Conversation

DDanii
Copy link
Contributor

@DDanii DDanii commented Apr 17, 2023

Proposed change

Fixes transmission error handling maybe fixes #85217

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @engrbm87, @JPHutchins, mind taking a look at this pull request as it has been labeled with an integration (transmission) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of transmission can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign transmission Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title transmission error handle fix Fix transmission error handling Apr 17, 2023
@home-assistant home-assistant bot marked this pull request as draft April 21, 2023 08:42
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@DDanii DDanii marked this pull request as ready for review April 25, 2023 15:26
@home-assistant home-assistant bot requested a review from gjohansson-ST April 25, 2023 15:26
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 26, 2023
@andreasc1
Copy link

can you push the update please?

@gjohansson-ST gjohansson-ST added this to the 2023.5.2 milestone May 5, 2023
@gjohansson-ST gjohansson-ST merged commit 9ce0624 into home-assistant:dev May 5, 2023
@gjohansson-ST gjohansson-ST removed the smash Indicator this PR is close to finish for merging or closing label May 5, 2023
@andreasc1
Copy link

thanks, hope to get the update soon

CoMPaTech pushed a commit to plugwise/home-assistant.core that referenced this pull request May 5, 2023
* transmission error handle fix

* added unexpected case tests
balloob pushed a commit that referenced this pull request May 5, 2023
* transmission error handle fix

* added unexpected case tests
@balloob balloob mentioned this pull request May 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If Transmission isnt available, the integration forgets login creds
5 participants