Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cloud migration #92520

Merged
merged 3 commits into from
May 5, 2023
Merged

Improve cloud migration #92520

merged 3 commits into from
May 5, 2023

Conversation

emontnemery
Copy link
Contributor

Proposed change

Improve cloud migration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2023.5.1 milestone May 4, 2023
@home-assistant
Copy link

home-assistant bot commented May 4, 2023

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck modified the milestones: 2023.5.1, 2023.5.2 May 4, 2023
@emontnemery emontnemery requested a review from balloob May 4, 2023 17:48
@balloob balloob requested review from ochlocracy and jbouwh as code owners May 5, 2023 02:25
@balloob balloob merged commit b6664ce into dev May 5, 2023
@balloob balloob deleted the cloud_improve_migration branch May 5, 2023 03:10
CoMPaTech pushed a commit to plugwise/home-assistant.core that referenced this pull request May 5, 2023
@emontnemery @balloob @CoMPaTech
Improve cloud migration (home-assistant#92520)
a8f129a 
* Improve cloud migration

* Tweak

* Use entity_ids func

---------

Co-authored-by: Paulus Schoutsen <[email protected]>
balloob added a commit that referenced this pull request May 5, 2023
@emontnemery @balloob
Improve cloud migration (#92520)
8a11ee8 
* Improve cloud migration

* Tweak

* Use entity_ids func

---------

Co-authored-by: Paulus Schoutsen <[email protected]>
@balloob balloob mentioned this pull request May 5, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@ochlocracy ochlocracy Awaiting requested review from ochlocracy ochlocracy is a code owner

@jbouwh jbouwh Awaiting requested review from jbouwh jbouwh is a code owner

Assignees
No one assigned
Labels
cherry-picked cla-signed core integration: cloud Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @frenck