Fix grouping feature for MusicCast

[micha91]

Proposed change

Due to the new source names from #74954 we were checking the current source by using the source names instead of the source ids. Long story short: We weren't taking care of the breaking change, we introduced there. This will be fixed by this PR so that the grouping features of MusicCast should now work again.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes MusicCast Group/Ungroup Broken #95945
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (yamaha_musiccast) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yamaha_musiccast can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign yamaha_musiccast Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[vigonotion]

Code looks good to me 👍🏻

[joostlek]

LGTM

[frenck]

Have been discussing this, mostly the original PR, so making this review to block this one for now.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[micha91]

Have been discussing this, mostly the original PR, so making this review to block this one for now.

Can you please link the original PR, you mentioned? If you are referring to #74954: That one was already merged and is part of the 2022.07 release. This PR fixes the bug, which was caused by #74954.

See Frencks review

[MartinHjelmare]

Yes, it's that PR that we are concerned about. We know it's been released. We're discussing reverting it.

[micha91]

Okay - if you are considering reverting it because of the ability to use translations in state attributes: I would love to use translations instead of renaming sources. But for sources, it makes no sense to use static translations. On MusicCast devices, you can rename sources in the MusicCast app. For example, my hdmi1 is renamed to Apple-TV, and that is the only thing that shows up in the device display and the MusicCast app. But for other users, hdmi1 might be renamed to XBOX, etc. If it were possible to let the device return translations/labels for sources, I would also prefer to go that way, but to my knowledge this is not the case, right?

[balloob]

This PR is good to go as these are user defined labels, and we cannot offer translations for those.