-
-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
Since Appdaemon v3 officially published, then we should change the default `conf` to meet with new format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, other than that it looks good.
type: hass | ||
ha_url: http://127.0.0.1:8123 | ||
ha_key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment out the key part?
If you see #142 it still fails if the ha_key: is blank..
#ha_key:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the issue. Did it mean that we should add latitude longitude time_zone... conf by default? But I search Appdaemon’s docs and these variables should be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is necessary, If you change ha_key:
to #ha_key:
it will start.
I'm working on setting the password if one is supplied in the script now.
correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :) thank you 🥇
Since Appdaemon v3 officially published, then we should change the default
conf
to meet with new format.Description:
Related issue (if applicable): Fixes #
Checklist:
If pertinent:
/docs