Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Allow reboot from script #72

Closed
wants to merge 1 commit into from
Closed

Conversation

olskar
Copy link
Contributor

@olskar olskar commented Nov 11, 2017

No description provided.

@@ -1,6 +1,6 @@
#!/bin/bash
function hassbian-show-short-info {
echo "Upgrade the base OS installation on this system"
echo "Home Assistant upgrade script for Hassbian"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this was reverted to an earlier version?

@ludeeus
Copy link
Member

ludeeus commented Nov 11, 2017

This could be an nice feature, but I belive that reboots only should happen when absolutely necessary and they should come organically, most users will hit "y" to every question whiteout reading it, and this will "force" an reboot upon them.

I like the Idea, but if implemented it should only trigger an query when apt reports that reboot is necessary (If that is even possible?)

@Landrash
Copy link
Collaborator

This change introduces a change from current packages and would require user intervention.
I prefer this change is only applied if the script is run by an actual user.

@Landrash Landrash modified the milestone: v0.7 Jan 27, 2018
@Landrash
Copy link
Collaborator

Landrash commented Feb 4, 2018

This functionality will currently not work with the feature set of #90 and forward. This might be included in the future but not in the current iteration.
Thank you for the PR and if you feel it can be reworked to function with the upcoming changes feel free to drop by for a chat in the #devs-hassbian Discord channel. 🍪

@Landrash Landrash closed this Feb 4, 2018
@Landrash Landrash reopened this Feb 4, 2018
@Landrash Landrash closed this Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants